Java version should be consistent for all tasks
"It has been possible to configure Gradle to build a project
with a different Java version than the one used to run Gradle. However,
it has required configuring each task like compilation, test, and javadoc separately.
Gradle 6.7 introduces “Java toolchain support”. In a nutshell,
it allows you to run Gradle with whatever version of Java you have installed,
while Gradle builds the project with the version of Java declared in a single place.
Gradle will automatically configure the build, detect already installed
JDKs and download the required JDK if it is not already installed."
More at https://blog.gradle.org/java-toolchains
Signed-off-by: Patryk Mis <foss@patrykmis.com>
All Gradle wrapper files were updated as per instructions from Android Gradle Plugin's release notes (with one exception explained below):
gradlew wrapper --gradle-version 7.6.1 --distribution-type bin --gradle-distribution-sha256-sum 6147605a23b4eff6c334927a86ff3508cb5d6722cd624c97ded4c2e8640f1f87
--gradle-distribution-sha256-sum switch ads additional verification of downloaded Gradle distribution (as explained at https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:verification) for security reasons.
Version 7.6.1 is the latest from v7.x.x series, which is supported by the Android Gradle Plugin v7.4.2.
It contains various improvements and fixes documented at https://docs.gradle.org/7.6.1/release-notes.html.
Keeping up to date with the latest versions is good practice for various reasons, including (but not limited to) potential security fixes.
Signed-off-by: Patryk Mis <foss@patrykmis.com>
Multiple substitutions specified in non-positional format of string resource string/app_list_rating. Did you mean to add the formatted="false" attribute?
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
- TOS URL redirects to play.google.com
- blob mode offers better formatting compared to raw
- Redirect to the valid FAQ page on wiki
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
There is no theme 0 which results in showing wrong accent preference
in customization settings if user doesn't selects a theme manually
during onboarding.
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Both Nullable and NonNull are java annotations and doesn't work on Kotlin.
Drop them to make lint happy.
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Translations are done by volunteers when possible, so no need to make it an error.
Also our translation platform has issues for now that makes it a legit case to be ignored.
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
We cannot rely on name of the file as on non-debug builds, resource optimization
renames the filename to a random string. Thus, we read the said property file
and only consider it if it has a valid UserReadableName.
Certain build time files also ends with .properties extension that results in
showing null otherwise. We are only shipping files supplied to us from
gplayapi library, so filter them with a matching regex.
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
- Going forward we aim to tag the gplayapi for better versioning.
- 3.0.1 which is the current version uses protobuf-javalite causes
issues when used with protobuf-java, so also switch to lite.
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
