AboutFragment: Format app version name and code properly
Appending version code to name confuses users regarding version they are using. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
This commit is contained in:
@@ -205,8 +205,11 @@ class MainActivity : AppCompatActivity() {
|
||||
transformations(RoundedCornersTransformation(8F))
|
||||
}
|
||||
it.findViewById<TextView>(R.id.txt_name)?.text = getString(R.string.app_name)
|
||||
it.findViewById<TextView>(R.id.txt_email)?.text =
|
||||
("v${BuildConfig.VERSION_NAME}.${BuildConfig.VERSION_CODE}")
|
||||
it.findViewById<TextView>(R.id.txt_email)?.text = getString(
|
||||
R.string.version,
|
||||
BuildConfig.VERSION_NAME,
|
||||
BuildConfig.VERSION_CODE
|
||||
)
|
||||
}
|
||||
|
||||
appConfig = AppBarConfiguration.Builder(topLevelFrags.toSet())
|
||||
|
||||
@@ -54,7 +54,11 @@ class AboutFragment : Fragment(R.layout.fragment_about) {
|
||||
|
||||
// About Details
|
||||
binding.imgIcon.load(R.mipmap.ic_launcher)
|
||||
binding.line2.text = ("v${BuildConfig.VERSION_NAME}(${BuildConfig.VERSION_CODE})")
|
||||
binding.line2.text = view.context.getString(
|
||||
R.string.version,
|
||||
BuildConfig.VERSION_NAME,
|
||||
BuildConfig.VERSION_CODE
|
||||
)
|
||||
|
||||
binding.epoxyRecycler.layoutManager =
|
||||
LinearLayoutManager(view.context, RecyclerView.VERTICAL, false)
|
||||
|
||||
@@ -428,4 +428,7 @@
|
||||
<string name="privacy_policy_title">Privacy policy</string>
|
||||
<string name="privacy_policy_subtitle">Learn how Aurora Store uses your data</string>
|
||||
<string name="disclaimer_subtitle">Accountability and responsibility</string>
|
||||
|
||||
<!-- AboutFragment -->
|
||||
<string name="version" translatable="false">v<xliff:g id="version_name">%1$s</xliff:g> (<xliff:g id="version_code">%2$d</xliff:g>)</string>
|
||||
</resources>
|
||||
|
||||
Reference in New Issue
Block a user