AppDetailsFragment: Drop uninstall menu action
Uninstall action is showed as a secondary action already when the app is installed Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
This commit is contained in:
@@ -429,7 +429,6 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
|
||||
requireContext(),
|
||||
app.packageName
|
||||
)
|
||||
it.findItem(R.id.action_uninstall)?.isVisible = app.isInstalled
|
||||
it.findItem(R.id.menu_app_settings)?.isVisible = app.isInstalled
|
||||
}
|
||||
|
||||
@@ -451,10 +450,6 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
|
||||
viewModel.toggleFavourite(app)
|
||||
}
|
||||
|
||||
R.id.action_uninstall -> {
|
||||
AppInstaller.uninstall(requireContext(), app.packageName)
|
||||
}
|
||||
|
||||
R.id.menu_download_manual -> {
|
||||
findNavController().navigate(
|
||||
AppDetailsFragmentDirections
|
||||
@@ -727,13 +722,11 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
|
||||
binding.toolbar.menu.apply {
|
||||
findItem(R.id.action_home_screen)?.isVisible =
|
||||
ShortcutManagerUtil.canPinShortcut(requireContext(), app.packageName)
|
||||
findItem(R.id.action_uninstall)?.isVisible = true
|
||||
findItem(R.id.menu_app_settings)?.isVisible = true
|
||||
}
|
||||
} else {
|
||||
binding.toolbar.menu.apply {
|
||||
findItem(R.id.action_home_screen)?.isVisible = false
|
||||
findItem(R.id.action_uninstall)?.isVisible = false
|
||||
findItem(R.id.menu_app_settings)?.isVisible = false
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,11 +0,0 @@
|
||||
<?xml version="1.0" encoding="utf-8"?>
|
||||
<vector xmlns:android="http://schemas.android.com/apk/res/android"
|
||||
android:width="24dp"
|
||||
android:height="24dp"
|
||||
android:tint="?attr/colorControlNormal"
|
||||
android:viewportWidth="960"
|
||||
android:viewportHeight="960">
|
||||
<path
|
||||
android:fillColor="@android:color/white"
|
||||
android:pathData="M280,840Q247,840 223.5,816.5Q200,793 200,760L200,240L160,240L160,160L360,160L360,120L600,120L600,160L800,160L800,240L760,240L760,760Q760,793 736.5,816.5Q713,840 680,840L280,840ZM680,240L280,240L280,760Q280,760 280,760Q280,760 280,760L680,760Q680,760 680,760Q680,760 680,760L680,240ZM360,680L440,680L440,320L360,320L360,680ZM520,680L600,680L600,320L520,320L520,680ZM280,240L280,240L280,760Q280,760 280,760Q280,760 280,760L280,760Q280,760 280,760Q280,760 280,760L280,240Z" />
|
||||
</vector>
|
||||
@@ -31,12 +31,6 @@
|
||||
android:title="@string/action_share"
|
||||
app:showAsAction="ifRoom" />
|
||||
|
||||
<item
|
||||
android:id="@+id/action_uninstall"
|
||||
android:icon="@drawable/ic_delete"
|
||||
android:title="@string/action_uninstall"
|
||||
app:showAsAction="ifRoom" />
|
||||
|
||||
<item
|
||||
android:id="@+id/menu_download_manual"
|
||||
android:title="@string/title_manual_download" />
|
||||
|
||||
Reference in New Issue
Block a user