From 71bad1e9b1942b9b28da0cd9fad19007a5f63213 Mon Sep 17 00:00:00 2001
From: Aayush Gupta <aayushgupta219@gmail.com>
Date: Mon, 30 Jun 2025 11:09:22 +0800
Subject: [PATCH] AppDetailsFragment: Drop uninstall menu action

Uninstall action is showed as a secondary action already when the
app is installed

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
---
 .../store/view/ui/details/AppDetailsFragment.kt       |  7 -------
 app/src/main/res/drawable/ic_delete.xml               | 11 -----------
 app/src/main/res/menu/menu_details.xml                |  6 ------
 3 files changed, 24 deletions(-)
 delete mode 100644 app/src/main/res/drawable/ic_delete.xml

diff --git a/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt b/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt
index 1491fe50b..cb13de62d 100644
--- a/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt
+++ b/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt
@@ -429,7 +429,6 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
                         requireContext(),
                         app.packageName
                     )
-                it.findItem(R.id.action_uninstall)?.isVisible = app.isInstalled
                 it.findItem(R.id.menu_app_settings)?.isVisible = app.isInstalled
             }
 
@@ -451,10 +450,6 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
                         viewModel.toggleFavourite(app)
                     }
 
-                    R.id.action_uninstall -> {
-                        AppInstaller.uninstall(requireContext(), app.packageName)
-                    }
-
                     R.id.menu_download_manual -> {
                         findNavController().navigate(
                             AppDetailsFragmentDirections
@@ -727,13 +722,11 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
             binding.toolbar.menu.apply {
                 findItem(R.id.action_home_screen)?.isVisible =
                     ShortcutManagerUtil.canPinShortcut(requireContext(), app.packageName)
-                findItem(R.id.action_uninstall)?.isVisible = true
                 findItem(R.id.menu_app_settings)?.isVisible = true
             }
         } else {
             binding.toolbar.menu.apply {
                 findItem(R.id.action_home_screen)?.isVisible = false
-                findItem(R.id.action_uninstall)?.isVisible = false
                 findItem(R.id.menu_app_settings)?.isVisible = false
             }
         }
diff --git a/app/src/main/res/drawable/ic_delete.xml b/app/src/main/res/drawable/ic_delete.xml
deleted file mode 100644
index 3e3991d97..000000000
--- a/app/src/main/res/drawable/ic_delete.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="24dp"
-    android:height="24dp"
-    android:tint="?attr/colorControlNormal"
-    android:viewportWidth="960"
-    android:viewportHeight="960">
-    <path
-        android:fillColor="@android:color/white"
-        android:pathData="M280,840Q247,840 223.5,816.5Q200,793 200,760L200,240L160,240L160,160L360,160L360,120L600,120L600,160L800,160L800,240L760,240L760,760Q760,793 736.5,816.5Q713,840 680,840L280,840ZM680,240L280,240L280,760Q280,760 280,760Q280,760 280,760L680,760Q680,760 680,760Q680,760 680,760L680,240ZM360,680L440,680L440,320L360,320L360,680ZM520,680L600,680L600,320L520,320L520,680ZM280,240L280,240L280,760Q280,760 280,760Q280,760 280,760L280,760Q280,760 280,760Q280,760 280,760L280,240Z" />
-</vector>
diff --git a/app/src/main/res/menu/menu_details.xml b/app/src/main/res/menu/menu_details.xml
index 4319b4837..05b1eb899 100644
--- a/app/src/main/res/menu/menu_details.xml
+++ b/app/src/main/res/menu/menu_details.xml
@@ -31,12 +31,6 @@
         android:title="@string/action_share"
         app:showAsAction="ifRoom" />
 
-    <item
-        android:id="@+id/action_uninstall"
-        android:icon="@drawable/ic_delete"
-        android:title="@string/action_uninstall"
-        app:showAsAction="ifRoom" />
-
     <item
         android:id="@+id/menu_download_manual"
         android:title="@string/title_manual_download" />