athaliar/APKDownloader
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DownloadWorker: Always run onSuccess block as NonCancellable

Browse Source 
* Change context in SessionInstaller when starting activity instead

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
This commit is contained in:
Aayush Gupta
2024-02-21 20:31:17 +05:30
parent 1108edc303
commit e0d1185f16
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/com/aurora/store/data/receiver/InstallerStatusReceiver.kt
View File

@@ -25,6 +25,7 @@ import android.content.Intent
import android.content.pm.PackageInstaller import android.content.pm.PackageInstaller
import android.util.Log import android.util.Log
import androidx.core.content.IntentCompat import androidx.core.content.IntentCompat
import com.aurora.extensions.runOnUiThread
import com.aurora.gplayapi.data.models.App import com.aurora.gplayapi.data.models.App
import com.aurora.store.R import com.aurora.store.R
import com.aurora.store.data.event.InstallerEvent import com.aurora.store.data.event.InstallerEvent
@@ -80,7 +81,7 @@ class InstallerStatusReceiver : BroadcastReceiver() {
it.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) it.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
try { try {
context.startActivity(it) runOnUiThread { context.startActivity(it) }
} catch (exception: Exception) { } catch (exception: Exception) {
Log.e(TAG, "Failed to trigger installation!", exception) Log.e(TAG, "Failed to trigger installation!", exception)
} }

7
app/src/main/java/com/aurora/store/data/work/DownloadWorker.kt
View File

@@ -20,7 +20,6 @@ import com.aurora.extensions.isSAndAbove
import com.aurora.extensions.requiresObbDir import com.aurora.extensions.requiresObbDir
import com.aurora.gplayapi.helpers.PurchaseHelper import com.aurora.gplayapi.helpers.PurchaseHelper
import com.aurora.store.data.installer.AppInstaller import com.aurora.store.data.installer.AppInstaller
import com.aurora.store.data.installer.SessionInstaller
import com.aurora.store.data.model.DownloadInfo import com.aurora.store.data.model.DownloadInfo
import com.aurora.store.data.model.DownloadStatus import com.aurora.store.data.model.DownloadStatus
import com.aurora.store.data.model.Request import com.aurora.store.data.model.Request
@@ -166,11 +165,9 @@ class DownloadWorker @AssistedInject constructor(
} }
private suspend fun onSuccess() { private suspend fun onSuccess() {
val installer = appInstaller.getPreferredInstaller() withContext(NonCancellable) {
val dispatcher = if (installer is SessionInstaller) Dispatchers.Main else NonCancellable
withContext(dispatcher) {
try { try {
installer.install(download) appInstaller.getPreferredInstaller().install(download)
} catch (exception: Exception) { } catch (exception: Exception) {
Log.e(TAG, "Failed to install ${download.packageName}", exception) Log.e(TAG, "Failed to install ${download.packageName}", exception)
} }