From dd584b5b7b00e7447e6b72fea8c7bf592176d910 Mon Sep 17 00:00:00 2001
From: Aayush Gupta <aayushgupta219@gmail.com>
Date: Thu, 22 Feb 2024 18:20:20 +0530
Subject: [PATCH] SplashFragment: Remove from backstack when launching an
 intent

SplashFragment always removes itself from backstack in every other case, do same
when launching the app detail page to handle intents as well.

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
---
 .../store/view/ui/splash/SplashFragment.kt       | 16 ++++++++++++----
 .../main/res/navigation/mobile_navigation.xml    |  6 ++++++
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/com/aurora/store/view/ui/splash/SplashFragment.kt b/app/src/main/java/com/aurora/store/view/ui/splash/SplashFragment.kt
index 32d0ddcc5..edbd37c4c 100644
--- a/app/src/main/java/com/aurora/store/view/ui/splash/SplashFragment.kt
+++ b/app/src/main/java/com/aurora/store/view/ui/splash/SplashFragment.kt
@@ -22,6 +22,7 @@ package com.aurora.store.view.ui.splash
 import android.content.Intent
 import android.os.Bundle
 import android.view.View
+import androidx.fragment.app.Fragment
 import androidx.fragment.app.activityViewModels
 import androidx.navigation.fragment.findNavController
 import coil.load
@@ -35,12 +36,11 @@ import com.aurora.store.databinding.FragmentSplashBinding
 import com.aurora.store.util.Preferences
 import com.aurora.store.util.Preferences.PREFERENCE_DEFAULT_SELECTED_TAB
 import com.aurora.store.util.Preferences.PREFERENCE_INTRO
-import com.aurora.store.view.ui.commons.BaseFragment
 import com.aurora.store.viewmodel.auth.AuthViewModel
 import dagger.hilt.android.AndroidEntryPoint
 
 @AndroidEntryPoint
-class SplashFragment : BaseFragment(R.layout.fragment_splash) {
+class SplashFragment : Fragment(R.layout.fragment_splash) {
 
     private var _binding: FragmentSplashBinding? = null
     private val binding get() = _binding!!
@@ -101,7 +101,11 @@ class SplashFragment : BaseFragment(R.layout.fragment_splash) {
                         navigateToDefaultTab()
                     } else {
                         requireArguments().remove("packageName")
-                        openDetailsFragment(packageName)
+                        findNavController().navigate(
+                            SplashFragmentDirections.actionSplashFragmentToAppDetailsFragment(
+                                packageName
+                            )
+                        )
                     }
                 }
 
@@ -121,7 +125,11 @@ class SplashFragment : BaseFragment(R.layout.fragment_splash) {
                         navigateToDefaultTab()
                     } else {
                         requireArguments().remove("packageName")
-                        openDetailsFragment(packageName)
+                        findNavController().navigate(
+                            SplashFragmentDirections.actionSplashFragmentToAppDetailsFragment(
+                                packageName
+                            )
+                        )
                     }
                 }
 
diff --git a/app/src/main/res/navigation/mobile_navigation.xml b/app/src/main/res/navigation/mobile_navigation.xml
index c8b25ed9d..c775272ac 100644
--- a/app/src/main/res/navigation/mobile_navigation.xml
+++ b/app/src/main/res/navigation/mobile_navigation.xml
@@ -355,6 +355,12 @@
         <action
             android:id="@+id/action_splashFragment_to_googleFragment"
             app:destination="@id/googleFragment" />
+        <action
+            android:id="@+id/action_splashFragment_to_appDetailsFragment"
+            app:destination="@id/appDetailsFragment"
+            app:launchSingleTop="true"
+            app:popUpTo="@id/mobile_navigation"
+            app:popUpToInclusive="true" />
     </fragment>
     <fragment
         android:id="@+id/googleFragment"