From bf5fe6ebe3fd844969f17b3323a79e05d8c4b95d Mon Sep 17 00:00:00 2001 From: Rahul Patel Date: Thu, 12 Oct 2023 18:53:38 +0530 Subject: [PATCH] Fix search issue --- app/build.gradle.kts | 2 +- .../viewmodel/search/SearchResultViewModel.kt | 19 ++----------------- .../search/SearchSuggestionViewModel.kt | 15 +++------------ 3 files changed, 6 insertions(+), 30 deletions(-) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index b2a2861a4..dd49353e6 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -164,7 +164,7 @@ dependencies { implementation("com.github.topjohnwu.libsu:core:5.0.5") //Love <3 - implementation("com.gitlab.AuroraOSS:gplayapi:3.2.0") + implementation("com.gitlab.AuroraOSS:gplayapi:3.2.1") //Browser implementation("androidx.browser:browser:1.6.0") diff --git a/app/src/main/java/com/aurora/store/viewmodel/search/SearchResultViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/search/SearchResultViewModel.kt index 4108f1ca4..5bda8e912 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/search/SearchResultViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/search/SearchResultViewModel.kt @@ -20,15 +20,12 @@ package com.aurora.store.viewmodel.search import android.app.Application -import android.content.Context import android.util.Log import androidx.lifecycle.MutableLiveData import androidx.lifecycle.viewModelScope import com.aurora.extensions.flushAndAdd -import com.aurora.extensions.shouldUseWebAPI import com.aurora.gplayapi.data.models.AuthData import com.aurora.gplayapi.data.models.SearchBundle -import com.aurora.gplayapi.helpers.SearchHelper import com.aurora.gplayapi.helpers.WebSearchHelper import com.aurora.store.data.RequestState import com.aurora.store.data.network.HttpClient @@ -45,11 +42,9 @@ class SearchResultViewModel(application: Application) : BaseAndroidViewModel(app .with(application) .getAuthData() - private val searchHelper: SearchHelper = SearchHelper(authData) + private val searchHelper = WebSearchHelper(authData) .using(HttpClient.getPreferredClient()) - private val webSearchHelper = WebSearchHelper() - val liveData: MutableLiveData = MutableLiveData() private var searchBundle: SearchBundle = SearchBundle() @@ -74,17 +69,7 @@ class SearchResultViewModel(application: Application) : BaseAndroidViewModel(app private fun search( query: String ): SearchBundle { - return if ((getApplication() as Context).shouldUseWebAPI()) { - val result = webSearchHelper.searchResults(query) - val searchBundle = SearchBundle().apply { - this.id = 100 - this.query = query - appList = result.values.flatten().toSet().toMutableList() - } - return searchBundle - } else { - searchHelper.searchResults(query) - } + return searchHelper.searchResults(query) } @Synchronized diff --git a/app/src/main/java/com/aurora/store/viewmodel/search/SearchSuggestionViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/search/SearchSuggestionViewModel.kt index 4a7d1518b..5c61a7fd4 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/search/SearchSuggestionViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/search/SearchSuggestionViewModel.kt @@ -20,15 +20,12 @@ package com.aurora.store.viewmodel.search import android.app.Application -import android.content.Context import androidx.lifecycle.AndroidViewModel import androidx.lifecycle.MutableLiveData import androidx.lifecycle.viewModelScope -import com.aurora.extensions.shouldUseWebAPI import com.aurora.gplayapi.SearchSuggestEntry import com.aurora.gplayapi.data.models.AuthData -import com.aurora.gplayapi.helpers.SearchHelper -import com.aurora.gplayapi.helpers.WebSearchSuggestionHelper +import com.aurora.gplayapi.helpers.WebSearchHelper import com.aurora.store.data.network.HttpClient import com.aurora.store.data.providers.AuthProvider import kotlinx.coroutines.Dispatchers @@ -40,11 +37,9 @@ class SearchSuggestionViewModel(application: Application) : AndroidViewModel(app .with(application) .getAuthData() - private val searchHelper: SearchHelper = SearchHelper(authData) + private val searchHelper = WebSearchHelper(authData) .using(HttpClient.getPreferredClient()) - private val webSearchSuggestionHelper = WebSearchSuggestionHelper() - val liveSearchSuggestions: MutableLiveData> = MutableLiveData() fun observeStreamBundles(query: String) { @@ -56,10 +51,6 @@ class SearchSuggestionViewModel(application: Application) : AndroidViewModel(app private fun getSearchSuggestions( query: String ): List { - return if ((getApplication() as Context).shouldUseWebAPI()) { - webSearchSuggestionHelper.searchSuggestions(query) - } else { - searchHelper.searchSuggestions(query) - } + return searchHelper.searchSuggestions(query) } }