BaseFragment: Explicity require packageName

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
This commit is contained in:
Aayush Gupta
2023-09-04 14:18:12 +05:30
parent ce2b6590bb
commit bc61639773
19 changed files with 27 additions and 22 deletions

View File

@@ -100,7 +100,7 @@ class InstalledAppsFragment : BaseFragment() {
AppListViewModel_() AppListViewModel_()
.id(app.id) .id(app.id)
.app(app) .app(app)
.click { _ -> openDetailsFragment(app) } .click { _ -> openDetailsFragment(app.packageName, app) }
.longClick { _ -> .longClick { _ ->
openAppMenuSheet(app) openAppMenuSheet(app)
false false

View File

@@ -114,7 +114,7 @@ class LibraryAppsFragment : BaseFragment() {
AppListViewModel_() AppListViewModel_()
.id(app.id) .id(app.id)
.app(app) .app(app)
.click { _ -> openDetailsFragment(app) } .click { _ -> openDetailsFragment(app.packageName, app) }
) )
} }

View File

@@ -114,7 +114,7 @@ class PurchasedAppsFragment : BaseFragment() {
AppListViewModel_() AppListViewModel_()
.id(app.id) .id(app.id)
.app(app) .app(app)
.click { _ -> openDetailsFragment(app) } .click { _ -> openDetailsFragment(app.packageName, app) }
.longClick { _ -> .longClick { _ ->
openAppMenuSheet(app) openAppMenuSheet(app)
false false

View File

@@ -129,7 +129,7 @@ class TopChartFragment : BaseFragment() {
AppListViewModel_() AppListViewModel_()
.id(app.id) .id(app.id)
.app(app) .app(app)
.click { _ -> openDetailsFragment(app) } .click { _ -> openDetailsFragment(app.packageName, app) }
) )
} }

View File

@@ -39,9 +39,9 @@ open class BaseFragment : Fragment {
Modifier.TRANSIENT Modifier.TRANSIENT
).create() ).create()
fun openDetailsFragment(app: App) { fun openDetailsFragment(packageName: String, app: App? = null) {
findNavController().navigate( findNavController().navigate(
MobileNavigationDirections.actionGlobalAppDetailsFragment(app.packageName, app) MobileNavigationDirections.actionGlobalAppDetailsFragment(packageName, app)
) )
} }

View File

@@ -130,7 +130,7 @@ class CategoryBrowseFragment : BaseFragment(R.layout.activity_generic_recycler),
} }
override fun onAppClick(app: App) { override fun onAppClick(app: App) {
openDetailsFragment(app) openDetailsFragment(app.packageName, app)
} }
override fun onAppLongClick(app: App) { override fun onAppLongClick(app: App) {

View File

@@ -130,7 +130,7 @@ class EarlyAccessFragment : BaseFragment(), GenericCarouselController.Callbacks
} }
override fun onAppClick(app: App) { override fun onAppClick(app: App) {
openDetailsFragment(app) openDetailsFragment(app.packageName, app)
} }
override fun onAppLongClick(app: App) { override fun onAppLongClick(app: App) {

View File

@@ -108,7 +108,7 @@ class EditorStreamBrowseFragment : BaseFragment(R.layout.activity_generic_recycl
AppListViewModel_() AppListViewModel_()
.id("app_${app.id}") .id("app_${app.id}")
.app(app) .app(app)
.click { _ -> openDetailsFragment(app) } .click { _ -> openDetailsFragment(app.packageName, app) }
) )
app.editorReason?.let { editorReason -> app.editorReason?.let { editorReason ->
@@ -120,7 +120,7 @@ class EditorStreamBrowseFragment : BaseFragment(R.layout.activity_generic_recycl
.joinToString(transform = { "\n$it" }) .joinToString(transform = { "\n$it" })
.substringAfter(delimiter = "\n") .substringAfter(delimiter = "\n")
) )
.click { _ -> openDetailsFragment(app) } .click { _ -> openDetailsFragment(app.packageName, app) }
) )
} }
@@ -138,7 +138,7 @@ class EditorStreamBrowseFragment : BaseFragment(R.layout.activity_generic_recycl
EditorHeadViewModel_() EditorHeadViewModel_()
.id("description_${app.id}") .id("description_${app.id}")
.title(editorReason.description) .title(editorReason.description)
.click { _ -> openDetailsFragment(app) } .click { _ -> openDetailsFragment(app.packageName, app) }
) )
} }
} }

View File

@@ -136,7 +136,7 @@ class ExpandedStreamBrowseFragment : BaseFragment(R.layout.activity_generic_recy
AppListViewModel_() AppListViewModel_()
.id(it.packageName.hashCode()) .id(it.packageName.hashCode())
.app(it) .app(it)
.click { _ -> openDetailsFragment(it) } .click { _ -> openDetailsFragment(it.packageName, it) }
) )
} }

View File

@@ -145,7 +145,7 @@ class ForYouFragment : BaseFragment(), GenericCarouselController.Callbacks {
} }
override fun onAppClick(app: App) { override fun onAppClick(app: App) {
openDetailsFragment(app) openDetailsFragment(app.packageName, app)
} }
override fun onAppLongClick(app: App) { override fun onAppLongClick(app: App) {

View File

@@ -103,7 +103,7 @@ class StreamBrowseFragment : BaseFragment(R.layout.activity_generic_recycler) {
AppListViewModel_() AppListViewModel_()
.id(it.packageName.hashCode()) .id(it.packageName.hashCode())
.app(it) .app(it)
.click { _ -> openDetailsFragment(it) } .click { _ -> openDetailsFragment(it.packageName, it) }
) )
} }

View File

@@ -1125,7 +1125,7 @@ class AppDetailsFragment : BaseFragment(R.layout.fragment_details) {
} }
override fun onAppClick(app: App) { override fun onAppClick(app: App) {
openDetailsFragment(app) openDetailsFragment(app.packageName, app)
} }
override fun onAppLongClick(app: App) { override fun onAppLongClick(app: App) {

View File

@@ -71,7 +71,7 @@ class DetailsMoreFragment : BaseFragment(R.layout.fragment_details_more) {
AppDependentViewModel_() AppDependentViewModel_()
.id(it.id) .id(it.id)
.app(it) .app(it)
.click { _ -> openDetailsFragment(it) } .click { _ -> openDetailsFragment(it.packageName, it) }
) )
} }
} }

View File

@@ -88,7 +88,7 @@ class DevAppsFragment : BaseFragment(R.layout.activity_generic_recycler) {
.id(app.id) .id(app.id)
.app(app) .app(app)
.click(View.OnClickListener { .click(View.OnClickListener {
openDetailsFragment(app) openDetailsFragment(app.packageName, app)
}) })
) )
} }

View File

@@ -117,7 +117,7 @@ class DevProfileFragment : BaseFragment(R.layout.fragment_dev_profile),
} }
override fun onAppClick(app: App) { override fun onAppClick(app: App) {
openDetailsFragment(app) openDetailsFragment(app.packageName, app)
} }
override fun onAppLongClick(app: App) { override fun onAppLongClick(app: App) {

View File

@@ -143,7 +143,7 @@ class TopChartFragment : BaseFragment() {
AppListViewModel_() AppListViewModel_()
.id(app.id) .id(app.id)
.app(app) .app(app)
.click { _ -> openDetailsFragment(app) } .click { _ -> openDetailsFragment(app.packageName, app) }
) )
} }

View File

@@ -92,7 +92,7 @@ class AppSalesFragment : BaseFragment(R.layout.activity_generic_recycler) {
AppListViewModel_() AppListViewModel_()
.id(it.packageName.hashCode()) .id(it.packageName.hashCode())
.app(it) .app(it)
.click { _ -> openDetailsFragment(it) } .click { _ -> openDetailsFragment(it.packageName, it) }
) )
setFilterDuplicates(true) setFilterDuplicates(true)
} }

View File

@@ -227,7 +227,7 @@ class SearchResultsFragment : BaseFragment(R.layout.fragment_search_result),
.id(app.id) .id(app.id)
.app(app) .app(app)
.click(View.OnClickListener { .click(View.OnClickListener {
openDetailsFragment(app) openDetailsFragment(app.packageName, app)
}) })
) )
} }

View File

@@ -242,7 +242,12 @@ class UpdatesFragment : BaseFragment() {
AppUpdateViewModel_() AppUpdateViewModel_()
.id(updateFile.hashCode()) .id(updateFile.hashCode())
.updateFile(updateFile) .updateFile(updateFile)
.click { _ -> openDetailsFragment(updateFile.app) } .click { _ ->
openDetailsFragment(
updateFile.app.packageName,
updateFile.app
)
}
.longClick { _ -> .longClick { _ ->
openAppMenuSheet(updateFile.app) openAppMenuSheet(updateFile.app)
false false