From a45dafc3d92a9f36f23c79ccec058aba50429157 Mon Sep 17 00:00:00 2001 From: Aayush Gupta Date: Wed, 11 Sep 2024 20:50:34 +0530 Subject: [PATCH] AppDetailsFragment: Move targetSdk info to more details fragment Since past few years Google has a target SDK requirement making this info not so useful as apps will sooner or later always target latest SDK. Ref: https://developer.android.com/google/play/requirements/target-sdk Signed-off-by: Aayush Gupta --- .../store/view/ui/details/AppDetailsFragment.kt | 1 - .../store/view/ui/details/DetailsMoreFragment.kt | 6 ++++++ .../main/res/layout/layout_details_description.xml | 12 ------------ 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt b/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt index e9e648183..e2ca6985b 100644 --- a/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt @@ -730,7 +730,6 @@ class AppDetailsFragment : BaseFragment() { txtSize.text = CommonUtil.addSiPrefix(app.size) txtRating.text = app.labeledRating - txtSdk.text = ("Target SDK ${app.targetSdk}") txtUpdated.text = app.updatedOn txtDescription.text = HtmlCompat.fromHtml( app.shortDescription, diff --git a/app/src/main/java/com/aurora/store/view/ui/details/DetailsMoreFragment.kt b/app/src/main/java/com/aurora/store/view/ui/details/DetailsMoreFragment.kt index d0c9d7a17..57d8b54cf 100644 --- a/app/src/main/java/com/aurora/store/view/ui/details/DetailsMoreFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/details/DetailsMoreFragment.kt @@ -38,6 +38,7 @@ import com.aurora.store.view.epoxy.views.details.MoreBadgeViewModel_ import com.aurora.store.view.ui.commons.BaseFragment import com.aurora.store.viewmodel.details.DetailsMoreViewModel import dagger.hilt.android.AndroidEntryPoint +import java.util.UUID import kotlinx.coroutines.launch @AndroidEntryPoint @@ -153,6 +154,11 @@ class DetailsMoreFragment : BaseFragment() { .badge(it) ) } + add( + InfoViewModel_() + .id(UUID.randomUUID().toString()) + .badge(mapOf("targets" to "API ${app.targetSdk}").entries.first()) + ) } } } diff --git a/app/src/main/res/layout/layout_details_description.xml b/app/src/main/res/layout/layout_details_description.xml index 0ece9757b..434963328 100644 --- a/app/src/main/res/layout/layout_details_description.xml +++ b/app/src/main/res/layout/layout_details_description.xml @@ -86,18 +86,6 @@ app:drawableTint="?colorAccent" tools:text="25 MB" /> - -