DownloadWorker: Drop non-required check for nullable packageName
packageName will never be null as App() constructor enforces specifiying packageName atleast similar to Download() class. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
This commit is contained in:
@@ -86,7 +86,6 @@ class DownloadWorker @AssistedInject constructor(
|
|||||||
|
|
||||||
object Exceptions {
|
object Exceptions {
|
||||||
class InvalidAuthDataException : Exception("AuthData is invalid")
|
class InvalidAuthDataException : Exception("AuthData is invalid")
|
||||||
class NoPackageNameException : Exception("No packagename provided")
|
|
||||||
class NoNetworkException : Exception("No network available")
|
class NoNetworkException : Exception("No network available")
|
||||||
class NothingToDownloadException : Exception("Failed to purchase app")
|
class NothingToDownloadException : Exception("Failed to purchase app")
|
||||||
class DownloadFailedException : Exception("Download failed")
|
class DownloadFailedException : Exception("Download failed")
|
||||||
@@ -102,12 +101,7 @@ class DownloadWorker @AssistedInject constructor(
|
|||||||
|
|
||||||
// Fetch required data for download
|
// Fetch required data for download
|
||||||
try {
|
try {
|
||||||
val packageName = inputData.getString(DownloadHelper.PACKAGE_NAME)
|
download = downloadDao.getDownload(inputData.getString(DownloadHelper.PACKAGE_NAME)!!)
|
||||||
|
|
||||||
// Bail out if no package name is provided
|
|
||||||
if (packageName.isNullOrBlank()) return onFailure(Exceptions.NoPackageNameException())
|
|
||||||
|
|
||||||
download = downloadDao.getDownload(packageName)
|
|
||||||
|
|
||||||
val response = (httpClient as HttpClient).call(download.iconURL).body
|
val response = (httpClient as HttpClient).call(download.iconURL).body
|
||||||
if (response != null) {
|
if (response != null) {
|
||||||
|
|||||||
Reference in New Issue
Block a user