From 79b3645a3ae5576f39cd5c32829d69f2e42e96df Mon Sep 17 00:00:00 2001
From: Patryk Mis <foss@patrykmis.com>
Date: Sat, 29 Apr 2023 13:58:13 +0200
Subject: [PATCH] Label icons for accessibility

Signed-off-by: Patryk Mis <foss@patrykmis.com>
---
 app/src/main/res/layout-v21/activity_main.xml   | 1 +
 app/src/main/res/layout/activity_main.xml       | 1 +
 app/src/main/res/layout/view_action_header.xml  | 3 ++-
 app/src/main/res/layout/view_app_update.xml     | 1 +
 app/src/main/res/layout/view_header.xml         | 3 ++-
 app/src/main/res/layout/view_header_shimmer.xml | 3 ++-
 app/src/main/res/layout/view_toolbar_action.xml | 3 ++-
 app/src/main/res/layout/view_toolbar_main.xml   | 4 +++-
 app/src/main/res/layout/view_toolbar_search.xml | 4 +++-
 app/src/main/res/values-pl/strings.xml          | 4 +++-
 app/src/main/res/values/strings.xml             | 2 ++
 11 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/app/src/main/res/layout-v21/activity_main.xml b/app/src/main/res/layout-v21/activity_main.xml
index 643235d9e..52b25711b 100644
--- a/app/src/main/res/layout-v21/activity_main.xml
+++ b/app/src/main/res/layout-v21/activity_main.xml
@@ -64,6 +64,7 @@
             android:layout_marginTop="@dimen/height_bottom_adj"
             android:layout_marginEnd="@dimen/margin_normal"
             android:layout_marginBottom="@dimen/height_bottom_adj"
+            android:contentDescription="@string/action_search"
             app:backgroundTint="?colorAccent"
             app:srcCompat="@drawable/ic_round_search"
             app:tint="@color/colorWhite"
diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml
index 40f5026ac..bd121ba53 100644
--- a/app/src/main/res/layout/activity_main.xml
+++ b/app/src/main/res/layout/activity_main.xml
@@ -64,6 +64,7 @@
             android:layout_marginTop="@dimen/height_bottom_adj"
             android:layout_marginEnd="@dimen/margin_normal"
             android:layout_marginBottom="@dimen/height_bottom_adj"
+            android:contentDescription="@string/action_search"
             app:backgroundTint="?colorAccent"
             app:srcCompat="@drawable/ic_round_search"
             app:tint="@color/colorWhite"
diff --git a/app/src/main/res/layout/view_action_header.xml b/app/src/main/res/layout/view_action_header.xml
index 021a150ad..870b941f3 100644
--- a/app/src/main/res/layout/view_action_header.xml
+++ b/app/src/main/res/layout/view_action_header.xml
@@ -60,6 +60,7 @@
         android:padding="@dimen/padding_xsmall"
         android:background="?selectableItemBackgroundBorderless"
         android:visibility="invisible"
+        android:contentDescription="@string/expand"
         app:srcCompat="@drawable/ic_arrow_right"
         app:tint="?android:textColorPrimary" />
-</RelativeLayout>
\ No newline at end of file
+</RelativeLayout>
diff --git a/app/src/main/res/layout/view_app_update.xml b/app/src/main/res/layout/view_app_update.xml
index 1a2997d78..595273b6d 100644
--- a/app/src/main/res/layout/view_app_update.xml
+++ b/app/src/main/res/layout/view_app_update.xml
@@ -118,6 +118,7 @@
                 android:clickable="true"
                 android:focusable="true"
                 android:padding="@dimen/margin_small"
+                android:contentDescription="@string/details_changelog"
                 app:srcCompat="@drawable/ic_arrow_right"
                 app:tint="?colorControlNormal" />
 
diff --git a/app/src/main/res/layout/view_header.xml b/app/src/main/res/layout/view_header.xml
index 39efa379b..4ab481c3b 100644
--- a/app/src/main/res/layout/view_header.xml
+++ b/app/src/main/res/layout/view_header.xml
@@ -59,6 +59,7 @@
         android:layout_marginStart="@dimen/margin_small"
         android:background="?selectableItemBackgroundBorderless"
         android:padding="@dimen/padding_xsmall"
+        android:contentDescription="@string/expand"
         app:srcCompat="@drawable/ic_arrow_right"
         app:tint="?android:textColorPrimary" />
-</RelativeLayout>
\ No newline at end of file
+</RelativeLayout>
diff --git a/app/src/main/res/layout/view_header_shimmer.xml b/app/src/main/res/layout/view_header_shimmer.xml
index 98a039d49..215e41e65 100644
--- a/app/src/main/res/layout/view_header_shimmer.xml
+++ b/app/src/main/res/layout/view_header_shimmer.xml
@@ -64,7 +64,8 @@
             android:layout_margin="@dimen/margin_small"
             android:background="?selectableItemBackgroundBorderless"
             android:padding="@dimen/padding_xsmall"
+            android:contentDescription="@string/expand"
             app:srcCompat="@drawable/ic_arrow_right"
             app:tint="?colorShimmer" />
     </RelativeLayout>
-</com.facebook.shimmer.ShimmerFrameLayout>
\ No newline at end of file
+</com.facebook.shimmer.ShimmerFrameLayout>
diff --git a/app/src/main/res/layout/view_toolbar_action.xml b/app/src/main/res/layout/view_toolbar_action.xml
index d02942fd0..a06aceeb1 100644
--- a/app/src/main/res/layout/view_toolbar_action.xml
+++ b/app/src/main/res/layout/view_toolbar_action.xml
@@ -33,6 +33,7 @@
         android:layout_centerVertical="true"
         android:layout_marginEnd="@dimen/margin_small"
         android:background="?selectableItemBackgroundBorderless"
+        android:contentDescription="@string/action_back"
         app:srcCompat="@drawable/ic_arrow_back"
         app:tint="?colorControlNormal" />
 
@@ -48,4 +49,4 @@
         android:paddingEnd="@dimen/padding_normal"
         android:singleLine="true"
         tools:text="Title" />
-</RelativeLayout>
\ No newline at end of file
+</RelativeLayout>
diff --git a/app/src/main/res/layout/view_toolbar_main.xml b/app/src/main/res/layout/view_toolbar_main.xml
index 8bf17ed61..1ddd3c5c5 100644
--- a/app/src/main/res/layout/view_toolbar_main.xml
+++ b/app/src/main/res/layout/view_toolbar_main.xml
@@ -33,6 +33,7 @@
         android:layout_marginEnd="@dimen/margin_small"
         android:background="?selectableItemBackgroundBorderless"
         android:padding="@dimen/padding_xxsmall"
+        android:contentDescription="@string/menu"
         app:srcCompat="@drawable/ic_menu_unfold"
         app:tint="?colorControlNormal" />
 
@@ -59,6 +60,7 @@
         android:layout_marginStart="@dimen/margin_small"
         android:background="?selectableItemBackgroundBorderless"
         android:padding="@dimen/padding_xxsmall"
+        android:contentDescription="@string/title_download_manager"
         app:srcCompat="@drawable/ic_download"
         app:tint="?colorControlNormal" />
-</RelativeLayout>
\ No newline at end of file
+</RelativeLayout>
diff --git a/app/src/main/res/layout/view_toolbar_search.xml b/app/src/main/res/layout/view_toolbar_search.xml
index a6b7a0df2..109122045 100644
--- a/app/src/main/res/layout/view_toolbar_search.xml
+++ b/app/src/main/res/layout/view_toolbar_search.xml
@@ -32,6 +32,7 @@
         android:layout_centerVertical="true"
         android:layout_marginEnd="@dimen/margin_small"
         android:background="?selectableItemBackgroundBorderless"
+        android:contentDescription="@string/action_back"
         app:srcCompat="@drawable/ic_arrow_back"
         app:tint="?colorControlNormal" />
 
@@ -58,6 +59,7 @@
         android:layout_centerVertical="true"
         android:layout_marginStart="@dimen/margin_small"
         android:background="?selectableItemBackgroundBorderless"
+        android:contentDescription="@string/title_download_manager"
         app:srcCompat="@drawable/ic_arrow_download"
         app:tint="?colorControlNormal" />
-</RelativeLayout>
\ No newline at end of file
+</RelativeLayout>
diff --git a/app/src/main/res/values-pl/strings.xml b/app/src/main/res/values-pl/strings.xml
index d17a60ae1..549832b3a 100644
--- a/app/src/main/res/values-pl/strings.xml
+++ b/app/src/main/res/values-pl/strings.xml
@@ -367,4 +367,6 @@
     <string name="ui_accent_8">Różowy</string>
     <string name="ui_accent_6">Fioletowy</string>
     <string name="ui_accent_10">Pomarańczowy</string>
-</resources>
\ No newline at end of file
+    <string name="menu">Menu</string>
+    <string name="expand">Rozwiń</string>
+</resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index d5faac3fc..8c551db02 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -403,4 +403,6 @@
     <string name="updates_available">updates available</string>
     <string name="rate_limited">Oops, This account is rate limited!</string>
     <string name="error">An error occurred!</string>
+    <string name="menu">Menu</string>
+    <string name="expand">Expand</string>
 </resources>