From 67197fbd91cc014516ff9c460e23da5db3b47688 Mon Sep 17 00:00:00 2001 From: Aayush Gupta Date: Thu, 13 Jul 2023 21:45:03 +0530 Subject: [PATCH] ScreenshotFragment: Pass artwork as array of parcel Signed-off-by: Aayush Gupta --- .../com/aurora/store/view/ui/commons/BaseFragment.kt | 2 +- .../store/view/ui/details/ScreenshotFragment.kt | 12 ++++-------- app/src/main/res/navigation/mobile_navigation.xml | 4 ++-- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/com/aurora/store/view/ui/commons/BaseFragment.kt b/app/src/main/java/com/aurora/store/view/ui/commons/BaseFragment.kt index dae6119ec..df2d0cae5 100644 --- a/app/src/main/java/com/aurora/store/view/ui/commons/BaseFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/commons/BaseFragment.kt @@ -89,7 +89,7 @@ open class BaseFragment : Fragment { findNavController().navigate( MobileNavigationDirections.actionGlobalScreenshotFragment( position, - gson.toJson(app.screenshots) + app.screenshots.toTypedArray() ) ) } diff --git a/app/src/main/java/com/aurora/store/view/ui/details/ScreenshotFragment.kt b/app/src/main/java/com/aurora/store/view/ui/details/ScreenshotFragment.kt index d3b0c706e..c37a3db7d 100644 --- a/app/src/main/java/com/aurora/store/view/ui/details/ScreenshotFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/details/ScreenshotFragment.kt @@ -22,6 +22,7 @@ package com.aurora.store.view.ui.details import android.os.Bundle import android.view.View import androidx.core.content.ContextCompat +import androidx.fragment.app.Fragment import androidx.navigation.fragment.findNavController import androidx.navigation.fragment.navArgs import androidx.recyclerview.widget.LinearLayoutManager @@ -31,10 +32,8 @@ import com.aurora.gplayapi.data.models.Artwork import com.aurora.store.R import com.aurora.store.databinding.FragmentScreenshotBinding import com.aurora.store.view.epoxy.views.details.LargeScreenshotViewModel_ -import com.aurora.store.view.ui.commons.BaseFragment -import com.google.gson.reflect.TypeToken -class ScreenshotFragment : BaseFragment(R.layout.fragment_screenshot) { +class ScreenshotFragment : Fragment(R.layout.fragment_screenshot) { private var _binding: FragmentScreenshotBinding? = null private val binding: FragmentScreenshotBinding @@ -42,8 +41,6 @@ class ScreenshotFragment : BaseFragment(R.layout.fragment_screenshot) { private val args: ScreenshotFragmentArgs by navArgs() - private lateinit var artworks: MutableList - override fun onViewCreated(view: View, savedInstanceState: Bundle?) { super.onViewCreated(view, savedInstanceState) _binding = FragmentScreenshotBinding.bind(view) @@ -61,8 +58,7 @@ class ScreenshotFragment : BaseFragment(R.layout.fragment_screenshot) { PagerSnapHelper().attachToRecyclerView(this) } - artworks = gson.fromJson(args.rawArtWorks, object : TypeToken?>() {}.type) - updateController(artworks, args.position) + updateController(args.arrayOfArtwork, args.position) } override fun onDestroyView() { @@ -70,7 +66,7 @@ class ScreenshotFragment : BaseFragment(R.layout.fragment_screenshot) { _binding = null } - private fun updateController(artworks: MutableList, position: Int) { + private fun updateController(artworks: Array, position: Int) { binding.recyclerView.withModels { artworks.forEach { add( diff --git a/app/src/main/res/navigation/mobile_navigation.xml b/app/src/main/res/navigation/mobile_navigation.xml index 27e56286d..c9527f956 100644 --- a/app/src/main/res/navigation/mobile_navigation.xml +++ b/app/src/main/res/navigation/mobile_navigation.xml @@ -167,8 +167,8 @@ android:name="position" app:argType="integer" /> + android:name="arrayOfArtwork" + app:argType="com.aurora.gplayapi.data.models.Artwork[]" />