athaliar/APKDownloader
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DownloadWorker: Notify dowload failure on network error as well

Browse Source 
We can do special handling when ready but failure is a failure regardless.
Notify the user about it.

Also remove non-required default exception parameter as all instances of onFailure
specify an appropriate exception.

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
This commit is contained in:
Aayush Gupta
2025-03-17 14:17:24 +08:00
parent 075c6e1c05
commit 655c7cd59f
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/com/aurora/store/data/work/DownloadWorker.kt
View File

@@ -205,7 +205,7 @@ class DownloadWorker @AssistedInject constructor(
} }
} }
private suspend fun onFailure(exception: Exception = Exception("Something went wrong!")): Result = private suspend fun onFailure(exception: Exception): Result =
withContext(NonCancellable) { withContext(NonCancellable) {
Log.i(TAG, "Job failed: ${download.packageName}", exception) Log.i(TAG, "Job failed: ${download.packageName}", exception)
@@ -218,10 +218,6 @@ class DownloadWorker @AssistedInject constructor(
notifyStatus(DownloadStatus.CANCELLED) notifyStatus(DownloadStatus.CANCELLED)
} }
is NoNetworkException -> {
// TODO: Notify user of network failure, maybe a notification & retry option
}
else -> { else -> {
notifyStatus(DownloadStatus.FAILED) notifyStatus(DownloadStatus.FAILED)
AuroraApp.events.send(InstallerEvent.Failed(download.packageName).apply { AuroraApp.events.send(InstallerEvent.Failed(download.packageName).apply {