From 496486fb3746a0551a3c112922dc478a7c1afbec Mon Sep 17 00:00:00 2001 From: Rahul Patel Date: Sat, 20 Jul 2024 03:39:24 +0530 Subject: [PATCH] Simplify layouts - [1/2] --- app/src/main/res/layout/fragment_apps.xml | 1 - .../main/res/layout/fragment_favourite.xml | 1 - app/src/main/res/layout/fragment_for_you.xml | 1 - .../res/layout/fragment_generic_recycler.xml | 1 - .../layout/fragment_generic_with_pager.xml | 9 +- .../layout/fragment_generic_with_toolbar.xml | 1 - .../res/layout/fragment_search_result.xml | 1 - .../res/layout/fragment_top_container.xml | 1 - app/src/main/res/layout/fragment_updates.xml | 1 - .../main/res/layout/layout_details_review.xml | 1 - app/src/main/res/layout/view_app.xml | 5 +- app/src/main/res/layout/view_app_list.xml | 6 +- app/src/main/res/layout/view_app_shimmer.xml | 5 +- app/src/main/res/layout/view_app_update.xml | 177 ++++++++---------- app/src/main/res/layout/view_category.xml | 6 +- app/src/main/res/layout/view_device.xml | 11 +- app/src/main/res/layout/view_header.xml | 35 ++-- .../main/res/layout/view_header_shimmer.xml | 37 ++-- .../main/res/layout/view_header_update.xml | 42 ++--- app/src/main/res/layout/view_locale.xml | 6 +- 20 files changed, 140 insertions(+), 208 deletions(-) diff --git a/app/src/main/res/layout/fragment_apps.xml b/app/src/main/res/layout/fragment_apps.xml index 5f9881e47..4d84369e6 100644 --- a/app/src/main/res/layout/fragment_apps.xml +++ b/app/src/main/res/layout/fragment_apps.xml @@ -29,7 +29,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:clipToPadding="false" - app:itemSpacing="@dimen/margin_normal" app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" app:stackFromEnd="false" tools:listitem="@layout/view_app_list" /> diff --git a/app/src/main/res/layout/fragment_favourite.xml b/app/src/main/res/layout/fragment_favourite.xml index ec04fbb7e..2084bc9d3 100644 --- a/app/src/main/res/layout/fragment_favourite.xml +++ b/app/src/main/res/layout/fragment_favourite.xml @@ -40,7 +40,6 @@ android:layout_below="@+id/toolbar" android:clipToPadding="true" android:paddingBottom="@dimen/height_bottom_adj" - app:itemSpacing="@dimen/margin_normal" app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" app:stackFromEnd="false" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_for_you.xml b/app/src/main/res/layout/fragment_for_you.xml index 25ea52ad8..575e4a6eb 100644 --- a/app/src/main/res/layout/fragment_for_you.xml +++ b/app/src/main/res/layout/fragment_for_you.xml @@ -28,7 +28,6 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:paddingBottom="@dimen/height_bottom_adj" - app:itemSpacing="@dimen/margin_normal" app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" app:stackFromEnd="false" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_generic_recycler.xml b/app/src/main/res/layout/fragment_generic_recycler.xml index 995b0324c..23d8c210b 100644 --- a/app/src/main/res/layout/fragment_generic_recycler.xml +++ b/app/src/main/res/layout/fragment_generic_recycler.xml @@ -28,7 +28,6 @@ android:layout_height="match_parent" android:clipToPadding="false" android:paddingBottom="@dimen/height_bottom_adj" - app:itemSpacing="@dimen/padding_small" app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" app:stackFromEnd="false" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_generic_with_pager.xml b/app/src/main/res/layout/fragment_generic_with_pager.xml index 6dc741feb..c0a617354 100644 --- a/app/src/main/res/layout/fragment_generic_with_pager.xml +++ b/app/src/main/res/layout/fragment_generic_with_pager.xml @@ -32,15 +32,14 @@ android:layout_height="wrap_content" android:layout_below="@id/layout_action_toolbar" android:background="@android:color/transparent" - android:paddingStart="@dimen/margin_large" - android:paddingEnd="@dimen/margin_large" - android:paddingBottom="@dimen/padding_small" + android:paddingStart="@dimen/margin_normal" + android:paddingEnd="@dimen/margin_normal" app:tabGravity="fill" app:tabIndicator="@drawable/tab_indicator" app:tabIndicatorHeight="2dp" app:tabMode="scrollable" - app:tabPaddingEnd="@dimen/padding_normal" - app:tabPaddingStart="@dimen/padding_normal" + app:tabPaddingEnd="@dimen/padding_small" + app:tabPaddingStart="@dimen/padding_small" app:tabTextAppearance="@style/TextAppearance.Aurora.Tab.Title" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_search_result.xml b/app/src/main/res/layout/fragment_search_result.xml index 5ae5ca5a8..accaa3bdf 100644 --- a/app/src/main/res/layout/fragment_search_result.xml +++ b/app/src/main/res/layout/fragment_search_result.xml @@ -46,7 +46,6 @@ android:layout_height="match_parent" android:layout_below="@+id/divider" android:paddingTop="@dimen/padding_normal" - app:itemSpacing="@dimen/margin_normal" tools:listitem="@layout/view_app_list" /> diff --git a/app/src/main/res/layout/fragment_top_container.xml b/app/src/main/res/layout/fragment_top_container.xml index 2a10291cb..5c59668dc 100644 --- a/app/src/main/res/layout/fragment_top_container.xml +++ b/app/src/main/res/layout/fragment_top_container.xml @@ -29,7 +29,6 @@ android:layout_height="match_parent" android:clipToPadding="true" android:paddingBottom="@dimen/height_bottom_adj" - app:itemSpacing="@dimen/margin_normal" app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" app:stackFromEnd="false" /> \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_updates.xml b/app/src/main/res/layout/fragment_updates.xml index 7a03b2dac..51cf2d668 100644 --- a/app/src/main/res/layout/fragment_updates.xml +++ b/app/src/main/res/layout/fragment_updates.xml @@ -45,7 +45,6 @@ android:layout_height="match_parent" android:clipToPadding="false" android:paddingBottom="@dimen/height_bottom_adj" - app:itemSpacing="@dimen/margin_normal" app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" app:stackFromEnd="false" tools:listitem="@layout/view_app_list" /> diff --git a/app/src/main/res/layout/layout_details_review.xml b/app/src/main/res/layout/layout_details_review.xml index 72582ee2c..26021c778 100644 --- a/app/src/main/res/layout/layout_details_review.xml +++ b/app/src/main/res/layout/layout_details_review.xml @@ -153,7 +153,6 @@ android:orientation="vertical" android:overScrollMode="never" android:scrollbars="none" - app:itemSpacing="@dimen/margin_normal" app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" tools:itemCount="4" tools:listitem="@layout/view_review" /> diff --git a/app/src/main/res/layout/view_app.xml b/app/src/main/res/layout/view_app.xml index b0024a6cd..7147f6bfe 100644 --- a/app/src/main/res/layout/view_app.xml +++ b/app/src/main/res/layout/view_app.xml @@ -19,6 +19,7 @@ @@ -26,9 +27,7 @@ android:id="@+id/img_icon" android:layout_width="@dimen/icon_size_cluster" android:layout_height="@dimen/icon_size_cluster" - android:layout_centerHorizontal="true" - android:layout_marginStart="@dimen/padding_xsmall" - android:layout_marginEnd="@dimen/padding_xsmall" /> + android:layout_centerHorizontal="true"/> + android:paddingStart="@dimen/padding_medium" + android:paddingTop="@dimen/padding_xsmall" + android:paddingEnd="@dimen/padding_small" + android:paddingBottom="@dimen/padding_xsmall"> + android:orientation="vertical" + android:padding="@dimen/padding_xsmall"> + android:paddingStart="@dimen/padding_medium" + android:paddingTop="@dimen/padding_small" + android:paddingEnd="@dimen/padding_small" + android:paddingBottom="@dimen/padding_small"> - + - + android:layout_height="match_parent" + android:layout_centerInParent="true" /> + + - + - + - - + - + - + - - - - - - - - - - - - + + android:padding="@dimen/padding_small" + > \ No newline at end of file diff --git a/app/src/main/res/layout/view_device.xml b/app/src/main/res/layout/view_device.xml index d709498ce..66005edb0 100644 --- a/app/src/main/res/layout/view_device.xml +++ b/app/src/main/res/layout/view_device.xml @@ -21,8 +21,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="horizontal" - android:paddingStart="@dimen/padding_normal" - android:paddingEnd="@dimen/padding_small"> + android:padding="@dimen/padding_small"> + android:layout_alignEnd="@id/line1" /> + android:layout_alignEnd="@id/line1" /> \ No newline at end of file diff --git a/app/src/main/res/layout/view_header.xml b/app/src/main/res/layout/view_header.xml index 4ab481c3b..7fdb14ccd 100644 --- a/app/src/main/res/layout/view_header.xml +++ b/app/src/main/res/layout/view_header.xml @@ -22,33 +22,22 @@ xmlns:tools="http://schemas.android.com/tools" android:id="@+id/layout" android:layout_width="wrap_content" - android:layout_height="wrap_content"> + android:layout_height="wrap_content" + android:paddingStart="@dimen/padding_medium" + android:paddingTop="@dimen/padding_xsmall" + android:paddingEnd="@dimen/padding_small" + android:paddingBottom="@dimen/padding_xsmall"> - - - - - - + android:ellipsize="end" + android:maxLines="1" + tools:text="Header" /> diff --git a/app/src/main/res/layout/view_header_shimmer.xml b/app/src/main/res/layout/view_header_shimmer.xml index 215e41e65..c764f5bec 100644 --- a/app/src/main/res/layout/view_header_shimmer.xml +++ b/app/src/main/res/layout/view_header_shimmer.xml @@ -27,33 +27,22 @@ + android:layout_height="wrap_content" + android:paddingStart="@dimen/padding_medium" + android:paddingTop="@dimen/padding_xsmall" + android:paddingEnd="@dimen/padding_small" + android:paddingBottom="@dimen/padding_xsmall"> - - - - - - + android:background="?colorShimmer" + android:ellipsize="end" + android:maxLines="1" /> diff --git a/app/src/main/res/layout/view_header_update.xml b/app/src/main/res/layout/view_header_update.xml index 4fcd92616..a6b9d04be 100644 --- a/app/src/main/res/layout/view_header_update.xml +++ b/app/src/main/res/layout/view_header_update.xml @@ -20,42 +20,30 @@ + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:paddingStart="@dimen/padding_medium" + android:paddingTop="@dimen/padding_xsmall" + android:paddingEnd="@dimen/padding_small" + android:paddingBottom="@dimen/padding_xsmall"> - - - - - - + android:ellipsize="end" + android:gravity="center_vertical" + android:maxLines="1" + tools:text="Header" /> diff --git a/app/src/main/res/layout/view_locale.xml b/app/src/main/res/layout/view_locale.xml index 56ae4a234..21c94eb01 100644 --- a/app/src/main/res/layout/view_locale.xml +++ b/app/src/main/res/layout/view_locale.xml @@ -21,8 +21,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="horizontal" - android:paddingStart="@dimen/padding_normal" - android:paddingEnd="@dimen/padding_small"> + android:padding="@dimen/padding_small"> @@ -48,6 +46,6 @@ android:layout_width="@dimen/icon_size_category" android:layout_height="@dimen/icon_size_category" android:layout_alignParentEnd="true" - android:layout_centerInParent="true" + android:layout_centerVertical="true" android:minWidth="0dp" />