From 124aa9bd552794ed844463289240276574a208ab Mon Sep 17 00:00:00 2001 From: Aayush Gupta Date: Wed, 25 Sep 2024 19:38:48 +0100 Subject: [PATCH] viewmodel: Get rid of unused lint supress The false-positive issue seems to have been fixed Signed-off-by: Aayush Gupta --- .../java/com/aurora/store/viewmodel/all/BlacklistViewModel.kt | 2 -- .../java/com/aurora/store/viewmodel/all/UpdatesViewModel.kt | 2 -- .../main/java/com/aurora/store/viewmodel/auth/AuthViewModel.kt | 2 -- .../store/viewmodel/browse/ExpandedStreamBrowseViewModel.kt | 2 -- .../com/aurora/store/viewmodel/browse/StreamBrowseViewModel.kt | 2 -- .../com/aurora/store/viewmodel/category/CategoryViewModel.kt | 2 -- .../com/aurora/store/viewmodel/details/DevProfileViewModel.kt | 2 -- .../com/aurora/store/viewmodel/homestream/StreamViewModel.kt | 2 -- .../java/com/aurora/store/viewmodel/review/ReviewViewModel.kt | 2 -- .../com/aurora/store/viewmodel/search/SearchResultViewModel.kt | 2 -- .../aurora/store/viewmodel/search/SearchSuggestionViewModel.kt | 2 -- .../store/viewmodel/subcategory/CategoryStreamViewModel.kt | 2 -- .../com/aurora/store/viewmodel/topchart/TopChartViewModel.kt | 2 -- 13 files changed, 26 deletions(-) diff --git a/app/src/main/java/com/aurora/store/viewmodel/all/BlacklistViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/all/BlacklistViewModel.kt index 3a73fbb45..946e0ef4f 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/all/BlacklistViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/all/BlacklistViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.all -import android.annotation.SuppressLint import android.content.Context import androidx.lifecycle.ViewModel import androidx.lifecycle.viewModelScope @@ -40,7 +39,6 @@ import java.util.Locale import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class BlacklistViewModel @Inject constructor( val blacklistProvider: BlacklistProvider, @ApplicationContext private val context: Context, diff --git a/app/src/main/java/com/aurora/store/viewmodel/all/UpdatesViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/all/UpdatesViewModel.kt index 5ff212300..20a5b68c8 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/all/UpdatesViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/all/UpdatesViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.all -import android.annotation.SuppressLint import android.util.Log import androidx.lifecycle.ViewModel import androidx.lifecycle.viewModelScope @@ -34,7 +33,6 @@ import kotlinx.coroutines.launch import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class UpdatesViewModel @Inject constructor( private val appUtil: AppUtil, private val downloadWorkerUtil: DownloadWorkerUtil, diff --git a/app/src/main/java/com/aurora/store/viewmodel/auth/AuthViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/auth/AuthViewModel.kt index bbde0a9cc..1b952fcff 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/auth/AuthViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/auth/AuthViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.auth -import android.annotation.SuppressLint import android.content.Context import android.util.Log import androidx.lifecycle.ViewModel @@ -47,7 +46,6 @@ import java.net.UnknownHostException import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class AuthViewModel @Inject constructor( val authProvider: AuthProvider, @ApplicationContext private val context: Context, diff --git a/app/src/main/java/com/aurora/store/viewmodel/browse/ExpandedStreamBrowseViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/browse/ExpandedStreamBrowseViewModel.kt index b1ad2aa6c..6d1b03b47 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/browse/ExpandedStreamBrowseViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/browse/ExpandedStreamBrowseViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.browse -import android.annotation.SuppressLint import android.content.Context import android.util.Log import androidx.lifecycle.MutableLiveData @@ -37,7 +36,6 @@ import kotlinx.coroutines.supervisorScope import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class ExpandedStreamBrowseViewModel @Inject constructor( @ApplicationContext private val context: Context, private val authProvider: AuthProvider, diff --git a/app/src/main/java/com/aurora/store/viewmodel/browse/StreamBrowseViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/browse/StreamBrowseViewModel.kt index f79492330..33ef574b4 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/browse/StreamBrowseViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/browse/StreamBrowseViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.browse -import android.annotation.SuppressLint import android.content.Context import android.util.Log import androidx.lifecycle.MutableLiveData @@ -38,7 +37,6 @@ import kotlinx.coroutines.supervisorScope import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class StreamBrowseViewModel @Inject constructor( @ApplicationContext private val context: Context, private val authProvider: AuthProvider, diff --git a/app/src/main/java/com/aurora/store/viewmodel/category/CategoryViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/category/CategoryViewModel.kt index 638450dfa..b3b3514ca 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/category/CategoryViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/category/CategoryViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.category -import android.annotation.SuppressLint import android.content.Context import android.util.Log import androidx.lifecycle.MutableLiveData @@ -39,7 +38,6 @@ import kotlinx.coroutines.launch import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class CategoryViewModel @Inject constructor( @ApplicationContext private val context: Context, private val authProvider: AuthProvider, diff --git a/app/src/main/java/com/aurora/store/viewmodel/details/DevProfileViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/details/DevProfileViewModel.kt index 99e00b888..a6d52bcb7 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/details/DevProfileViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/details/DevProfileViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.details -import android.annotation.SuppressLint import android.content.Context import android.util.Log import androidx.lifecycle.MutableLiveData @@ -42,7 +41,6 @@ import kotlinx.coroutines.supervisorScope import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class DevProfileViewModel @Inject constructor( @ApplicationContext private val context: Context, private val authProvider: AuthProvider, diff --git a/app/src/main/java/com/aurora/store/viewmodel/homestream/StreamViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/homestream/StreamViewModel.kt index 1c952a20c..c07cbf499 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/homestream/StreamViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/homestream/StreamViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.homestream -import android.annotation.SuppressLint import android.content.Context import android.util.Log import androidx.lifecycle.MutableLiveData @@ -40,7 +39,6 @@ import kotlinx.coroutines.supervisorScope import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class StreamViewModel @Inject constructor( @ApplicationContext private val context: Context, private val httpClient: IHttpClient diff --git a/app/src/main/java/com/aurora/store/viewmodel/review/ReviewViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/review/ReviewViewModel.kt index 0ed54438f..265478e32 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/review/ReviewViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/review/ReviewViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.review -import android.annotation.SuppressLint import android.content.Context import androidx.lifecycle.MutableLiveData import androidx.lifecycle.ViewModel @@ -37,7 +36,6 @@ import kotlinx.coroutines.supervisorScope import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class ReviewViewModel @Inject constructor( @ApplicationContext private val context: Context, private val authProvider: AuthProvider, diff --git a/app/src/main/java/com/aurora/store/viewmodel/search/SearchResultViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/search/SearchResultViewModel.kt index 665cbc17f..da350584b 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/search/SearchResultViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/search/SearchResultViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.search -import android.annotation.SuppressLint import android.content.Context import android.util.Log import androidx.lifecycle.MutableLiveData @@ -41,7 +40,6 @@ import kotlinx.coroutines.supervisorScope import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class SearchResultViewModel @Inject constructor( val filterProvider: FilterProvider, @ApplicationContext private val context: Context, diff --git a/app/src/main/java/com/aurora/store/viewmodel/search/SearchSuggestionViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/search/SearchSuggestionViewModel.kt index 32980ca47..0dc0e0754 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/search/SearchSuggestionViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/search/SearchSuggestionViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.search -import android.annotation.SuppressLint import android.content.Context import androidx.lifecycle.MutableLiveData import androidx.lifecycle.ViewModel @@ -37,7 +36,6 @@ import kotlinx.coroutines.launch import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class SearchSuggestionViewModel @Inject constructor( @ApplicationContext private val context: Context, private val authProvider: AuthProvider, diff --git a/app/src/main/java/com/aurora/store/viewmodel/subcategory/CategoryStreamViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/subcategory/CategoryStreamViewModel.kt index 125c88320..6310cddf5 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/subcategory/CategoryStreamViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/subcategory/CategoryStreamViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.subcategory -import android.annotation.SuppressLint import android.content.Context import android.util.Log import androidx.lifecycle.MutableLiveData @@ -40,7 +39,6 @@ import kotlinx.coroutines.supervisorScope import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class CategoryStreamViewModel @Inject constructor( @ApplicationContext private val context: Context, private val httpClient: IHttpClient diff --git a/app/src/main/java/com/aurora/store/viewmodel/topchart/TopChartViewModel.kt b/app/src/main/java/com/aurora/store/viewmodel/topchart/TopChartViewModel.kt index faed405c6..787e368bb 100644 --- a/app/src/main/java/com/aurora/store/viewmodel/topchart/TopChartViewModel.kt +++ b/app/src/main/java/com/aurora/store/viewmodel/topchart/TopChartViewModel.kt @@ -19,7 +19,6 @@ package com.aurora.store.viewmodel.topchart -import android.annotation.SuppressLint import android.content.Context import androidx.lifecycle.MutableLiveData import androidx.lifecycle.ViewModel @@ -38,7 +37,6 @@ import kotlinx.coroutines.supervisorScope import javax.inject.Inject @HiltViewModel -@SuppressLint("StaticFieldLeak") // false positive, see https://github.com/google/dagger/issues/3253 class TopChartViewModel @Inject constructor( @ApplicationContext private val context: Context, private val httpClient: IHttpClient